Skip to content

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Jan 16, 2026

I use rank = compute_rank(...) regularly to process data. It works when then used as compute_covariance(..., rank=rank) and with make_inverse_operator(..., rank=rank). It should also work with plot_evoked_white.

EDIT: Note that the rank passed to make_inverse_operator etc. actually needs the "meg" key, not separate "mag" and "grad", so perhaps "meg" should actually be the preferred way to do it anyway. 🤷

Fixes failures seen in mne-tools/mne-bids-pipeline#1159

@larsoner
Copy link
Member Author

@nordme can you review + merge if you're happy?

@larsoner larsoner enabled auto-merge (squash) February 9, 2026 14:24
@larsoner larsoner disabled auto-merge February 9, 2026 14:24
@larsoner
Copy link
Member Author

larsoner commented Feb 9, 2026

CircleCI failure is the expected 45 missing refs, going to merge to keep things moving here and in mne-bids-pipeline!

@larsoner larsoner merged commit 8b8edb0 into mne-tools:main Feb 9, 2026
31 of 34 checks passed
@larsoner larsoner deleted the white branch February 9, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants