Skip to content

[typescript-koa] add router options support #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paztis wants to merge 3 commits into from
Closed

[typescript-koa] add router options support #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5f231c
[typescript-koa] add router options support
paztis Mar 15, 2026
182e542
[typescript-koa] Make RouterOptions optional in createRouterExportName
paztis Mar 15, 2026
42aa499
[typescript-fetch] Fix default response signature
Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...-code-generator/src/typescript/client/typescript-fetch/typescript-fetch-client-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,15 @@ export class TypescriptFetchClientBuilder extends AbstractClientBuilder {
const query = builder.query()
const headers = builder.headers({nullContentTypeValue: "undefined"})

const returnType = builder
.returnType()
.map(({statusType, responseType}) => {
return `Res<${statusType},${responseType}>`
const builderReturnType = builder.returnType()
const nonDefaultStatusTypes = builderReturnType
.filter(({isDefault}) => !isDefault)
.map(({statusType}) => statusType)
const returnType = builderReturnType
.map(({statusType, responseType, isDefault}) => {
return isDefault ?
`Res<Exclude<StatusCode, ${nonDefaultStatusTypes.join(" | ")}>,${responseType}>` :
`Res<${statusType},${responseType}>`
})
.join(" | ")

Expand Down
6 changes: 3 additions & 3 deletions ...napi-code-generator/src/typescript/server/typescript-koa/typescript-koa-router-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class KoaRouterBuilder extends AbstractRouterBuilder {
.add("KoaRuntimeError", "RequestInputType")

this.imports.from("koa").addType("Next")
this.imports.from("@koa/router").addType("RouterContext").all("KoaRouter")
this.imports.from("@koa/router").addType("RouterContext").addType("RouterOptions").all("KoaRouter")

const schemaBuilderType = this.schemaBuilder.type

Expand Down Expand Up @@ -258,8 +258,8 @@ ${this.operationTypes.flatMap((it) => it.statements).join("\n\n")}

${this.implementationExport(implementationExportName)}

export function ${createRouterExportName}(implementation: ${implementationExportName}): KoaRouter {
const router = new KoaRouter()
export function ${createRouterExportName}(implementation: ${implementationExportName}, options?: RouterOptions): KoaRouter {
const router = new KoaRouter(options)

${routerStatements.join("\n\n")}

Expand Down