Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
bkorycki
reviewed
Apr 3, 2026
Contributor
bkorycki
left a comment
bkorycki
left a comment
There was a problem hiding this comment.
This looks great! I really appreciate all the comments. It made the code easy to follow.
Sorry for all the comments. Mostly just clarification questions and nit picky suggestions.
bkorycki
reviewed
Apr 13, 2026
bkorycki
approved these changes
Apr 13, 2026
Contributor
bkorycki
left a comment
bkorycki
left a comment
There was a problem hiding this comment.
lgtm! I just have the one question but don't let it block you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building blocks for building DAG-like evaluators. You can see how it's used here: https://github.com/mlcommons/modelplane-flights/pull/6