chore: add issue templates, expand CONTRIBUTING.md, and project management setup#272
Merged
chore: add issue templates, expand CONTRIBUTING.md, and project management setup#272
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Code Review
This pull request establishes a comprehensive project management infrastructure for the repository. It introduces standardized issue templates for bugs, features, performance, and datasets, alongside a significantly expanded CONTRIBUTING.md that details development setup, code style, and testing procedures. The PR also includes a design specification and a task-based implementation plan for migrating issues and configuring a project board. Review feedback focused on correcting pytest-asyncio marker usage, refining coverage commands, and improving the robustness of shell scripts for GitHub token retrieval.
nvzhihanj
commented
Apr 8, 2026
2f2b15b to
fc391d7
Compare
arekay-nv
approved these changes
Apr 10, 2026
…, and CONTRIBUTING.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
13-task plan covering labels, board, templates, CONTRIBUTING.md, issue migration, duplicate closure, PR linkages, and board automation setup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Four YAML-based issue form templates: - 100-bug-report.yml: structured bug reporting - 200-feature-request.yml: feature proposals with motivation - 300-performance.yml: performance regressions with benchmark data - 400-dataset-integration.yml: new dataset/eval requests - config.yml: template chooser with Discussions link Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ue guidelines Replace minimal 10-line CONTRIBUTING.md with comprehensive guide covering: - Ways to contribute with links to issue templates - Development setup (venv, pip install, pre-commit, echo server) - Code style (ruff, mypy, conventional commits, serialization) - Testing (pytest markers, async mode, coverage, fixtures) - PR process and review expectations - Issue lifecycle and priority levels - MLCommons CLA requirements Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
One-way sync: when priority: or area: labels change on an issue, the corresponding board custom field is automatically updated. Labels are the single source of truth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove .cursor/rules/ (migrated to CLAUDE.md/AGENTS.md) - Remove docs/superpowers/ plans and specs (local-only artifacts) - Add .cursor/ and docs/superpowers/ to .gitignore - Overhaul README.md: remove emojis, remove inline contributor list (use git log/ATTRIBUTION instead), align architecture section with AGENTS.md, add badges, streamline to match OSS best practices - Contributors section removed — credit lives in git history and ATTRIBUTION file Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Strict asyncio mode is configured globally in pyproject.toml via asyncio_mode = "strict". The marker does not accept a mode argument — passing it causes errors in recent pytest-asyncio versions. Fixed in: CONTRIBUTING.md, AGENTS.md, docs/DEVELOPMENT.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CLA details are already in CONTRIBUTING.md — no need to duplicate in README. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Make it explicit that pre-commit must run before every commit, no exceptions. Hooks may modify files — stage changes and commit once. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove Discussions link from issue template config.yml and CONTRIBUTING.md since GitHub Discussions is not enabled on this repo. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8d9a66f to
d75f3c6
Compare
…ign with AGENTS.md - Fix repo URL: mlperf/inference-endpoint → mlcommons/endpoints - Add proper fork workflow (fork → clone → add upstream → branch → PR) - Update project structure to match current codebase (add evaluation, sglang, plugins, async_utils; fix entry point main.py not cli.py) - Remove emoji headers for consistency - Fix test example: add required markers, correct asyncio usage - Remove "skip hooks" advice (contradicts project policy) - Remove verbose docstring example (contradicts minimal-comments policy) - Remove Discussions references (feature not enabled) - Add YAML config templates section - Add performance considerations aligned with AGENTS.md - Add key test fixtures section Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What was done (via API, not in this PR)
The following was configured directly on GitHub via the API as part of this project management setup:
Test plan