Link with prebuilt OpenBLAS and fix shared libs build on Windows #3036
+33
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiltgen
approved these changes
Jan 22, 2026
| EXCLUDE_FROM_ALL) | ||
| set(BUILD_STATIC_LIBS ON) # link statically | ||
| set(NOFORTRAN ON) # msvc has no fortran compiler | ||
| URL "https://github.com/OpenMathLib/OpenBLAS/releases/download/v0.3.31/OpenBLAS-0.3.31-x64.zip" |
Contributor
There was a problem hiding this comment.
fwiw, I've also been playing around with trying to get things building on Windows ARM64, which needed patching of the OpenBLAS cmake files to get all the variables set up properly for LLVM-MinGW.
Collaborator
Author
There was a problem hiding this comment.
OpenBLAS provides binaries for Windows ARM64 (the woa64 files), can we just link with that?
zcbenz
force-pushed
the
openblas-dynamic-lib
branch
from
4d42605 to
950fd70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3031.
Close #3020.
This PR links MLX with the prebuilt dynamic library of OpenBLAS on Windows instead of building it from source code, which can save a lot of build time. (Note that we can not do static-linking, check the comments for more.)
Which then requires changing the locations where libraries and executables are generated, as Windows requires the DLL and EXE files be in the same directory (as there is no equivalent of RPATH on Windows):
tests/test.exe)binsub-dir)Note that the locations are only changed for Windows, and only when MLX is the top project, for projects that include MLX as a third party library there is nothing changed.
/cc @dhiltgen