Skip to content

Conversation

@MillaFleurs
Copy link
Contributor

Proposed changes

Fixes a potential seg fault wherein utils.h defaults to a nullptr but utils.cpp doesn't check to see if it's actually passed a nullptr issue #3007 .

Checklist

Put an x in the boxes that apply.

  • [ X] I have read the CONTRIBUTING document
  • [ X] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [ X] I have updated the necessary documentation (if needed)

Copy link
Collaborator

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check null before calling the callback as caller may pass null themselves.

@angeloskath
Copy link
Member

Thanks @MillaFleurs for the find and fix and @zcbenz for the fix of fix :-) Let's merge after the tests pass.

@angeloskath angeloskath merged commit 9a277a2 into ml-explore:main Jan 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants