Merged
Conversation
pawamoy
approved these changes
Jul 9, 2025
Member
pawamoy
left a comment
pawamoy
left a comment
There was a problem hiding this comment.
Thanks a lot! Preview is fine, I'd like to switch to some kind of automated screenshots at some point, let's keep current previews simple.
The change is easy enough, we'll add e2e tests if the option starts affecting or being affected by other options in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #292
@pawamoy Please let me know if I should change the preview docs somehow, wasn't sure how to structure it.
Also, do we want e2e tests for this?