Addressed issue #64: preserve query parameters#75
Open
pacenathan wants to merge 1 commit intomkdocs:masterfrom
Open
Addressed issue #64: preserve query parameters#75pacenathan wants to merge 1 commit intomkdocs:masterfrom
pacenathan wants to merge 1 commit intomkdocs:masterfrom
Conversation
Author
|
Note: In the case of redirect with query parameter and anchor, you can watch the query parameter send through, and the search term stays in the search field. So the modified javascript is preserving both after the redirect, but the scroll-to-anchor behavior closes the search interface itself, as one would expect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested in these 4 cases:
Worked in all 4 cases.