test(ts-plugin): move named exports tests into per-feature test files#359
Merged
test(ts-plugin): move named exports tests into per-feature test files#359
Conversation
Previously, named exports tests were consolidated in a single file (named-exports.test.ts) with only limited coverage. This commit moves those tests into the corresponding per-feature test files (code-fix, completion, find-all-references, go-to-definition) and adds test cases for behaviors that differ between named exports and default exports. Note: not all feature test files received named exports test cases — only features with code paths or behaviors that differ between the two export modes were updated. Features that share the same code path or are already sufficiently covered by other tests were left unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
mizdra
added
Type: Refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
named-exports.test.tswhich had limited coverage for named exports scenarioscode-fix.test.ts,completion.test.ts,find-all-references.test.ts, andgo-to-definition.test.tsimport * as styles) and default exports (import styles) modesMotivation
The previous approach of grouping all named exports tests in a single file made it harder to understand what behaviors were covered per feature, and left many named-exports-specific behaviors untested. By co-locating named exports tests with their feature counterparts, coverage is improved and test intent becomes clearer.
Test plan
vp test --project e2eand confirm all tests passnamed-exports.test.tsscenarios are covered by the updated per-feature test files🤖 Generated with Claude Code