Fix add second variable in local_declaration_statement block #76
Conversation
|
I found another issue: the warning icon on getter/setter blocks doesn’t disappear once the problem is resolved. It only clears after a reload. Screencast.from.2025-08-27.09-40-04.webmThis appears to happen because |
|
@TannerGabriel thanks, great you fixed another issue too! To make it easier to review, would you mind splitting them up? I say this knowing my Blockly 11 fixes are all in one PR. I'll squash it all into main in one commit (with you as a co-author) from my PR once App Inventor Blockly 11 branch is further along in testing and we're confident we've caught most issues. Definitely submit anything you find with 11, or let us know any bugs you notice. Additionally anything you find in Blockly 12, but not 11 can go against my 12 upgrade branch and eventually we'll get it all in main. Thanks! |
|
@mjgallag I split the changes into separate PRs. Do you already have an approximate timeline on when the V11 and V12 updates will be merged? |
|
Thanks @TannerGabriel I will take a look at these this week. Not entirely sure, probably best to npm install from a github branch if you want changes now because I think we'll wait to merge this until it seems to be working well in App Inventor as then we'll know it's pretty well tested. We should be starting testing on 11 next week but it can take a while to get to production. I'll test if npm install from github works this week, it would need to trigger build step. |
|
Ok, thanks. I’ll probably test the V12 update later this week and get it working with my personal project. After that, I can report back on which changes are required. |
|
@TannerGabriel that'd be helpful, thanks! |
2 participants
Fix for the issue that occurs when adding a second variable to the
local_declaration_statementstarting with Blockly V11, which was discussed in #68.