Add embed link type#127
Closed
shibaobun wants to merge 2 commits intomisskey-dev:developfrom
Closed
Conversation
shibaobun
force-pushed
the
link-modes
branch
2 times, most recently
from
ea39d78 to
9d5277b
Compare
shibaobun
force-pushed
the
link-modes
branch
2 times, most recently
from
45d34a2 to
396abd9
Compare
Author
|
@syuilo this one has also been freshly updated 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies
This branch is based on the changes proposed in #126, since it adds some additional test cases testing modes + URL features like brackets.
936be73 shows changes after #126, so that might be easier to review.
However, I can happily repush this branch without #126 improvements if needed!
What
silentboolean into astringfor additional link modesembedtype for embedding images, likeWhy
in MisskeyAdditional info (optional)
I am very new to typescript, so please let me know if there's anything that can be changed for best practice!
Thank you!