Skip to content

mcfix#1

Open
miranov25 wants to merge 328 commits intomasterfrom
mcfix
Open

mcfix#1
miranov25 wants to merge 328 commits intomasterfrom
mcfix

Conversation

@miranov25
Copy link
Owner

No description provided.

sawenzel and others added 30 commits July 15, 2025 07:51
Inject a concrete production tag into the workflow
instead of reading it from a shell variable.
There is no need to depend on a (potentially changeable) runtime environment.
Suggested by David Rohr. Hoping to fix a rare crash in trdreco2.
Seems to work better indeed in local tests.
It should be enough, and less confusing, to just specify the number
of timeframes to be simulated (as well as potentially the timeframe length in orbits).

So we now do the setting for NSIGEVENTS internally (the o2dpg_sim_workflow script
still needs it) but keep the option to provide it for expert studies.

Also taking away the need to provide CYCLE (which is mostly 0 in any case).
Co-authored-by: Francesco Mazzaschi <fmazzasc@alipap1.cern.ch>
Co-authored-by: Francesco Mazzaschi <fmazzasc@alipap1.cern.ch>
* New files for producing eventpool of undecayed XiC

* add scripts for testing the new .ini files
Co-authored-by: Lucamicheletti93 <luca.mike93@gmail.com>
Co-authored-by: Francesco Mazzaschi <fmazzasc@alipap1.cern.ch>
…liceO2Group#2069)

* Add configurations for MC production for SigmaC background studies.

* Add test macro.

* Fix names

---------

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Co-authored-by: Lucamicheletti93 <luca.mike93@gmail.com>
* non-prompt psi2s to jpsi pipi

* remove unused code

* small change in decay name

---------

Co-authored-by: Yiping Wang <yipwang@lxbk1131.gsi.de>
* Add option to have AO2Ds with prepropagated tracks

* Update setenv_extra.sh
* Update zdc.json

new config for oxigen, proton and ne

* Update zdcPbPb.json

* Update zdcPbPb.json

fixed error bin in histograms TDCAZEMvsTDCT

* Update zdc.json

Add Data sources for Post Processing

* Update zdc.json

Adjust Bin TDCAH and ADCH
* added EPOS4 generator for pp collisions at 13 TeV

* added validation routine
sawenzel and others added 25 commits January 28, 2026 10:33
* beautification of configuration
* coupling to task-finalizer to be able to inject config-keys from outside
* make sensitive to GPU_proc_nn for the ML clusterization keys
* Configs for Lc resonance prod.

* Fixing PDG numbering scheme for PDG codes
* Add possibility to enable time gain calibration

This PR enables the option to create the time gain calibration objects by setting ALIEN_JDL_DOTPCTIMEGAINCALIB=1.
The output files are named `o2tpc_CalibratordEdx_Histos_<run>_<startTime>_<endTime>_<startTF>_<endTF>.root` and need to be merged afterwards to get enough statistics for the fits.

* Add option to specify scale events and tracks
…up#2245)

* new ini for gap triggerd strangeness MC for pp ref energy

* adding test

---------

Co-authored-by: Lucia Anna Tarasovicova <lucia.anna.husova@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
…#2259)

* Add generator for Ropes in pp 5.36 TeV

* Add EPOS generator for pp 5.36 TeV

* fix epos ini file
This change makes it possible to use the external generator for debug purposes.
…2262)

* [PWGDQ] Extending rapidity range for charmonia in pO

* Shifting generated rapidity

* Same for Psi2S

* fixing mistake and ading missing test

* dummy commit

---------

Co-authored-by: Maurice Coquet <mcoquet@alicecerno2.cern.ch>
* first comit

* Fix missing new line

* Add Pythia8 Forced Dalitz test config for pp 13.6 TeV

* update

* update

---------

Co-authored-by: Laura Gansbartl <lgansbartl@pcikf5.ikf.uni-frankfurt.de>
* Update 13.6 TeV config to use gap 2

With the improved understanding of track migration, we can reduce the gap to 2 for all productions

* Corresponding update of test to use gap 2

* Unify naming scheeme to include sqrt_s

This makes the difference between the 5.36 and 13.6 much clearer

* Fix typo in name

* Corresponding name update
AliceO2Group#2255)

* Files required for an O2DPG production of prompt-photon MC, with a gap trigger

* Changed production ratio in testing files
* Implementation of parallel testing
* Central PbPb generator with strangeness

* update test
kMaxInvPt to 2 (pt>0.5)
make the inv_pt independent of the pt scale
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available

miranov25 added a commit that referenced this pull request Mar 12, 2026
Bug #1: weights parameter silently ignored in regression (used only
for aggregation stats). V1 numpy, V2 numba, and V3 incremental paths
all performed OLS regardless of weights.

Fix #1: Apply sqrt(w) transform to X and y before regression:
  - V1: X_weighted = X * sqrt(w), y_weighted = y * sqrt(w) before lstsq
  - V2: falls back to V1 when weights present (consistent with V5 pattern)
  - V3: XtX = Xw'Xw, XtY = Xw'yw in sufficient stats
  - V5: no change (already falls back to V3 when weights present)
  R²/RMSE on unweighted residuals (documented convention).

Bug AliceO2Group#2: fit_intercept=False still produced intercept columns with 0/NaN.

Fix AliceO2Group#2: _assemble_results + _assemble_results_v5 skip intercept columns
when fit_intercept=False.

Also includes V3 agg_columns support (was missing from committed version).

Tests: 13 new (7 WLS/intercept + 6 agg_columns), all pass
  433 passed, 30 failed (pre-existing V4/V5), 19 skipped
miranov25 pushed a commit that referenced this pull request Mar 12, 2026
…an output

Feature: agg_columns parameter for COG/window statistics
  - mean/std of user-specified columns within SW window
  - All 3 paths: zerocopy, V3 incremental, V5 numba
  - Canonical pattern: agg_columns = gb_columns + linear_columns

Bug #1 (P0): weights silently ignored in regression — fixed
Bug AliceO2Group#2 (P0): fit_intercept=False produced intercept columns — fixed

Interface: removed default fit_column stats (architect decision)
  - 52 → ~28 columns for 4-target fits
  - Use agg_columns to opt-in

Tests: 15 new, 6 files updated
  462 passed, 3 failed (pre-existing), 19 skipped, 0 regressions

Reviewed-by: Claude14, GPT7, GPT10, Claude (Opus)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.