nit: prefer cannonical classes #178
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pqoqubbw
reviewed
Jan 29, 2026
| <Menu.Item | ||
| className={cn( | ||
| "group relative flex w-full cursor-pointer select-none items-center justify-between gap-2 rounded-md px-2 py-1 text-sm outline-0 hover:bg-stone-950/[0.03] focus:bg-stone-950/5 data-[disabled]:pointer-events-none data-[disabled]:cursor-default data-[disabled]:opacity-50 dark:focus:bg-white/5 dark:hover:bg-white/[0.03]", | ||
| "group relative flex w-full cursor-pointer select-none items-center justify-between gap-2 rounded-md px-2 py-1 text-sm outline-0 hover:bg-stone-950/[0.03] focus:bg-stone-950/5 data-disabled:pointer-events-none data-disabled:cursor-default data-disabled:opacity-50 dark:focus:bg-white/5 dark:hover:bg-white/[0.03]", |
Contributor
There was a problem hiding this comment.
can you please update these ones as well:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
replaces
data-[disabled]withdata-disabledto not have any unnecessary brackets on the markup 😅 super nit.Note
Low Risk
Styling-only changes to how disabled state is expressed/selected; main risk is missed selector parity causing incorrect disabled visuals or pointer-events.
Overview
Standardizes disabled-state styling selectors from
data-[disabled]/data-[disabled="true"]todata-disabledinBadgeand code-groupDropdownMenuItem.Badgenow omits thedata-disabledattribute when not disabled (disabled || undefined) and updates related Tailwind selectors for cursor, colors, and icon styling to match the new attribute form.Written by Cursor Bugbot for commit f1af41a. This will update automatically on new commits. Configure here.