Fix BungeeCord dependency resolution for CI builds #21
+24
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add includeTransitiveDeps parameter to provided() function - Disable transitive deps for bungeecord-proxy (following Floodgate pattern) - Use separate API and proxy dependency versions matching BungeeCord releases - Fixes Sonatype SNAPSHOT repository resolution issues in CI
- Rename artifact names from "Floodgate" to "Connect" - Update actions/setup-java from v2 to v4 - Add gradle/actions/setup-gradle@v3 - Add fetch-depth: 0 for git describe versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
includeTransitiveDepsparameter toprovided()function in build-logicContext
The CI build was failing because the Sonatype SNAPSHOT repository had issues resolving transitive dependencies for BungeeCord. This follows the same pattern used by Floodgate/GeyserMC projects.
Test plan