-
Notifications
You must be signed in to change notification settings - Fork 17
Updates mindsdb-sql-parser version #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucas-koontz
wants to merge
7
commits into
main
Choose a base branch
from
STRC-539
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the mindsdb-sql-parser dependency to the latest version to leverage new features and bug fixes. Addresses compatibility issues and improves SQL parsing capabilities. STRC-539
Increment the package version number to reflect the latest release. STRC-539
added 3.12, 3.13
.github/workflows/release.yml
Outdated
| matrix: | ||
| os: [ubuntu-latest] | ||
| python-version: ['3.8', '3.9', '3.10', '3.11'] | ||
| python-version: ['3.9', '3.10', '3.11', '3.12', '3.13'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctness: The pinned pip==22.0.4 in the install step is incompatible with Python 3.13. Upgrade to pip>=24.0 to support the new matrix entry.
🤖 AI Agent Prompt for Cursor/Windsurf
📋 Copy this prompt to your AI coding assistant (Cursor, Windsurf, etc.) to get help fixing this issue
File: .github/workflows/release.yml, Line 13
Problem: Python 3.13 was added to the CI test matrix, but this may cause failures if dependencies don't support it yet.
Action Required:
1. Test locally with Python 3.13 to verify all dependencies install and tests pass
2. Check if the pinned pip version (22.0.4 from line 22) supports Python 3.13
3. Review all packages in requirements.txt and requirements_test.txt for Python 3.13 compatibility
4. Consider adding Python 3.13 in a separate PR after validation, or mark it as 'allow-failure' initially
5. If keeping 3.13, update pip to a version that officially supports Python 3.13
ea-rus
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Please describe what changes you made in as much detail as possible
mindsdb-sql-parserdependency to version 0.13.7. This upgrade likely includes bug fixes, performance improvements, and potentially new features in the SQL parsing library.Relates to STRC-539