Skip to content

Conversation

@betaboon
Copy link
Contributor

@betaboon betaboon commented Dec 3, 2024

this PR builds on #276.

it adds remaining typing, configures mypy and marks the package as typed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@coveralls
Copy link

Coverage Status

coverage: 97.261% (-1.4%) from 98.68%
when pulling 3dbbc4d on betaboon:typing
into 9cfad4c on mindflayer:main.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 97.261% (-1.4%) from 98.68%
when pulling 3dbbc4d on betaboon:typing
into 9cfad4c on mindflayer:main.

@coveralls
Copy link

Coverage Status

coverage: 97.261% (-1.4%) from 98.68%
when pulling 3dbbc4d on betaboon:typing
into 9cfad4c on mindflayer:main.

@mindflayer
Copy link
Owner

mindflayer commented Dec 5, 2024

Finding out what changed seems very difficult in here. It was already challenging with the previous PRs, I am finding it hard with these last two, and it's not even the first time I look at them.

@mindflayer
Copy link
Owner

I'm sorry, this went a "little" overboard 🙈

Now I fully understand your comment ^^

@betaboon
Copy link
Contributor Author

betaboon commented Dec 5, 2024

yep.
I'd suggest: let's ignore this PR for now, as it just builds on top of the other to finish up the typing.

let's use the other PR to discuss if and what we want to do with it.

@mindflayer
Copy link
Owner

mindflayer commented Mar 22, 2025

I've just changed the module structure according to what was previously discussed under your other PR. I am still open to accept a PR for completing the typing, and I believe the project has a better structure today mostly thanks to your initiative.

@mindflayer mindflayer closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants