Skip to content

Target make safetest got broken #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mindflayer merged 4 commits into from
Dec 21, 2024
Merged

Target make safetest got broken #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0983678
Only running tests that don't use real sockets got broken.
mindflayer Nov 25, 2024
5405e2e
Fix `Makefile`.
mindflayer Nov 25, 2024
998ad42
Merge branch 'main' into make-safetest-got-broken
mindflayer Dec 21, 2024
99a1b99
Adding CIENT SETINFO commands.
mindflayer Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ types:
test: types
@echo "Running Python tests"
uv pip uninstall pook || true
export VIRTUAL_ENV=.venv; .venv/bin/wait-for-it --service httpbin.local:443 --service localhost:6379 --timeout 5 -- .venv/bin/pytest
.venv/bin/wait-for-it --service httpbin.local:443 --service localhost:6379 --timeout 5 -- .venv/bin/pytest
uv pip install pook && .venv/bin/pytest tests/test_pook.py && uv pip uninstall pook
@echo ""

safetest:
export SKIP_TRUE_REDIS=1; export SKIP_TRUE_HTTP=1; make test
export SKIP_TRUE_REDIS=1; export SKIP_TRUE_HTTP=1; .venv/bin/pytest

publish: clean install-test-requirements
uv run python3 -m build --sdist --wheel .
Expand Down
1 change: 1 addition & 0 deletions tests/test_mocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ def test_patch(


@pytest.mark.skipif(not psutil.POSIX, reason="Uses a POSIX-only API to test")
@pytest.mark.skipif('os.getenv("SKIP_TRUE_HTTP", False)')
@pytest.mark.asyncio
async def test_no_dangling_fds():
url = "http://httpbin.local/ip"
Expand Down
4 changes: 3 additions & 1 deletion tests/test_redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,11 @@ def setUp(self):
self.rclient = redis.StrictRedis()

def mocketize_setup(self):
Entry.register_response("CLIENT SETINFO LIB-NAME redis-py", OK)
Entry.register_response(f"CLIENT SETINFO LIB-VER {redis.__version__}", OK)
Entry.register_response("FLUSHDB", OK)
self.rclient.flushdb()
self.assertEqual(len(Mocket.request_list()), 1)
self.assertEqual(len(Mocket.request_list()), 3)
Mocket.reset()

@mocketize
Expand Down