Open
Conversation
There was a simple repeating pattern that could be made more DRY with a map.
TheJaredWilcurt
commented
Apr 8, 2021
| osType = 'WSL'; | ||
| } | ||
|
|
||
| return osType.toLowerCase(); |
Author
There was a problem hiding this comment.
Store all of the logic for determining the OS in one function. Keeps all the related code together. Also easier for unit testing if you ever decide to do that. May want to move this to the utils file.
TheJaredWilcurt
commented
Apr 8, 2021
| windows_7_and_below: WindowsBalloon, | ||
| windows_nt: WindowsToaster, | ||
| wsl: WindowsToaster | ||
| }; |
Author
There was a problem hiding this comment.
Convert the giant Switch block over to a simple object that maps the the only two unique pieces of information, the OS and the notifier to use.
TheJaredWilcurt
commented
Apr 8, 2021
| wsl: WindowsToaster | ||
| }; | ||
|
|
||
| var osNotifier = osMap[getOsType()] || Growl; |
Author
There was a problem hiding this comment.
Get the correct OS, use that to get the correct notifier, or default to Growl.
TheJaredWilcurt
commented
Apr 8, 2021
|
|
||
| // Set the notifier specific to the current OS | ||
| module.exports = new osNotifier(options); | ||
| module.exports.Notification = osNotifier; |
Author
There was a problem hiding this comment.
No longer repeated 7 times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a simple repeating pattern that could be made more DRY with a map.