Fixed issue notifications do not show in Electron application#225
Open
hungkoala wants to merge 3 commits intomikaelbr:masterfrom
Open
Fixed issue notifications do not show in Electron application#225hungkoala wants to merge 3 commits intomikaelbr:masterfrom
hungkoala wants to merge 3 commits intomikaelbr:masterfrom
Conversation
added 3 commits
March 7, 2018 12:52
Owner
|
Hi! Thanks for submitting a PR. Could you summerize the gist of the changes? Are there any breaking changes? |
Owner
|
Also the changes of 736106e, are they ment to be a part of this PR? |
|
Ping @hungkoala |
|
Just a subtle nudge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron package.json example
"build": { "asarUnpack": [ "./app/node_modules/node-notifier/vendor/**" ], "extraResources": [ { "from": "./app/node_modules/node-notifier/vendor", "to": "app.asar.unpacked/node_modules/node-notifier/vendor" } ]