Use dedicated storage live migration condition to gauge success #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akalenyu
force-pushed
the
storage-live-migration-condition
branch
from
462cdc9 to
5c8006c
Compare
bumping properly to 1.4/5.0 is a pain (requires ctrl runtime/k8s deps bump) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
use the storage live migration condition instead of the regular shared pvc migration condition Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu
force-pushed
the
storage-live-migration-condition
branch
from
5c8006c to
4d1ef2a
Compare
awels
approved these changes
Sep 19, 2025
Contributor
Author
|
@awels should we merge? |
Collaborator
|
Lets wait for @rayfordj to give us the green light. |
Collaborator
|
@rayfordj we can start merging PRs now right? |
awels
approved these changes
Dec 3, 2025
rayfordj
approved these changes
Dec 9, 2025
Contributor
rayfordj
left a comment
rayfordj
left a comment
There was a problem hiding this comment.
/lgtm
/approve
good to proceed with merges for 1.8.12 now that 1.8.11 has released.
jpeimer
pushed a commit
to jpeimer/mig-controller
that referenced
this pull request
Dec 9, 2025
…ools#1453) * bump kubevirt api for storagelivemigratable condition bumping properly to 1.4/5.0 is a pain (requires ctrl runtime/k8s deps bump) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Use storage live migration condition use the storage live migration condition instead of the regular shared pvc migration condition Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> --------- Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
rayfordj
pushed a commit
that referenced
this pull request
Dec 9, 2025
… (#1457) * bump kubevirt api for storagelivemigratable condition bumping properly to 1.4/5.0 is a pain (requires ctrl runtime/k8s deps bump) * Use storage live migration condition use the storage live migration condition instead of the regular shared pvc migration condition --------- Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> Co-authored-by: Alex Kalenyuk <akalenyu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the dedicated storage live migration condition instead of the regular shared PVC migration condition