Clean up completed virt-launcher pods after migration completes. #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeimer
reviewed
Jul 16, 2025
jpeimer
left a comment
jpeimer
left a comment
There was a problem hiding this comment.
Thanks Alexander!
Just a nit comment
| return nil | ||
| } | ||
|
|
||
| func (t *Task) cleanupStaleVirtHandlerPods() error { |
There was a problem hiding this comment.
Suggested change
| func (t *Task) cleanupStaleVirtHandlerPods() error { | |
| func (t *Task) cleanupStaleVirtLauncherPods() error { |
completes. Fixes: https://issues.redhat.com/browse/MIG-1749 Signed-off-by: Alexander Wels <awels@redhat.com>
awels
force-pushed
the
delete_source_virt_launcher_after_migration
branch
from
ee4a066 to
73b6438
Compare
dymurray
approved these changes
Jul 16, 2025
pranavgaikwad
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/MIG-1749
Apparently if there completed virt-launchers, deleting the migration plan will cause a rollback to happen.