[WIP] feat(PageDrawer): Add PageDrawer component from tackle2-ui #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
|
🚀 Deployed Storybook Preview: http://migtools-lib-ui-pr-124-preview.surge.sh ✨ |
mturley
changed the title
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, need to come back to this when there isn't high-priority work.
So far I copied the code from tackle2-ui, renamed the PageDrawerContent component to PageDrawer (seems to make more sense if we're matching the Modal render pattern since that isn't called ModalContent), addressed some eslint warnings.
The reason I'm stopping work for now is that I'm not sure exactly how to render an example for this in Storybook since it requires being high up in the page structure of a PatternFly page.
TODO: figure out how to render a full-page preview/demo in Storybook, or maybe just document this without an example.