Improved Logging and Bug Fixes #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrvere
changed the title
- added a new file 'rfe.go' to store all open rfes which are shown in logs - added Logger field to ConvertOptions - added Info logs for docker strategy migration flow - created a separate function getServiceAccountName - fixed tests because of logger changes - go mod tidy - Bug1: migrated buildconfig's namespace - Bug2: corrected incorrect handling of volumes in docker strategy migration. It's not supported yet. - Bug3: added namespace in from field - Bug4: processSource function was not checking if b.Spec.Source exits already. This led to overwriting this field. Fixed it. Signed-off-by: Prateek Rathore <prathore@redhat.com>
psrvere
force-pushed
the
improve-logging
branch
from
410a793 to
9dc289c
Compare
jmontleon
approved these changes
Dec 10, 2025
Contributor
jmontleon
left a comment
jmontleon
left a comment
There was a problem hiding this comment.
LGTM. Seems straight forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging Improvements and Bug Fixes:
Signed-off-by: Prateek Rathore prathore@redhat.com