Skip to content

Fix depends on Bug #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
musale merged 6 commits into from
Nov 21, 2024
Merged

Fix depends on Bug #702

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77603a4
fix add event with depends on
shemogumbe Oct 8, 2024
5711d4f
Enable batch request with content collection
shemogumbe Oct 8, 2024
97e198e
Merge branch 'main' into shem/fix_add_depends_on_bug
shemogumbe Oct 22, 2024
6d22af2
Merge branch 'main' into shem/fix_add_depends_on_bug
shemogumbe Nov 9, 2024
765dbfe
Remove request wrapping in batch collection POST
musale Nov 18, 2024
0289e2f
Fix failing formatting
musale Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/msgraph_core/requests/batch_request_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ async def _post_batch_collection(

for batch_request_content in batch_request_content_collection.batches:
request_info = await self.to_post_request_information(batch_request_content)
Comment thread
baywet marked this conversation as resolved.
Outdated
bytes_content = request_info.content
json_content = bytes_content.decode("utf-8")
updated_str = '{"requests":' + json_content + '}'
updated_bytes = updated_str.encode("utf-8")
request_info.content = updated_bytes
response = await self._request_adapter.send_async(
request_info, BatchResponseContent, error_map or self.error_map
)
Expand Down
2 changes: 1 addition & 1 deletion src/msgraph_core/requests/batch_request_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def add_request(self, request_id: Optional[str], request: BatchRequestItem) -> N
request.id = str(uuid.uuid4())
if hasattr(request, 'depends_on') and request.depends_on:
for dependent_id in request.depends_on:
if dependent_id not in [req.id for req in self.requests]:
if dependent_id not in self.requests:
dependent_request = self._request_by_id(dependent_id)
if dependent_request:
self._requests[dependent_id] = dependent_request
Expand Down