fix: improve text selection contrast in Solarized Light#301572
Open
TomasMartinsFerreira wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: improve text selection contrast in Solarized Light#301572TomasMartinsFerreira wants to merge 2 commits intomicrosoft:mainfrom
TomasMartinsFerreira wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Solarized Light theme’s editor text selection color to improve selection visibility/contrast and better match existing selection styling used elsewhere in the theme.
Changes:
- Update
editor.selectionBackgroundfrom#EEE8D5to#878b9180in the Solarized Light theme.
You can also share your feedback on Copilot code review. Take the survey.
Fixes microsoft#297509 Update editor.selectionBackground from #EEE8D5 to #878b9180. The previous color lacked sufficient contrast, making it difficult to distinguish selected text from the background. The new color matches existing selection background logic used in other parts of the theme, ensuring visual consistency and better accessibility.
TomasMartinsFerreira
force-pushed
the
test
branch
from
81d5d2d to
7506b7f
Compare
Include minimap.selectionHighlight Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
Hello @jo-oikawa , is there any news about this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297509
Solution
Update
editor.selectionBackgroundfrom #EEE8D5 to #878b9180. Theprevious color lacked sufficient contrast, making it difficult to
distinguish selected text from the background. The new color matches
existing selection background logic used in other parts of the theme,
ensuring visual consistency and better accessibility.
Result
Before Fix
After Fix