Skip to content

Conversation

@eli-w-king
Copy link
Contributor

@eli-w-king eli-w-king commented Jan 27, 2026

@eli-w-king eli-w-king added ux User experience issues 2026-themes Issues related to the 2026 light and dark themes labels Jan 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the 2026 theme with several visual fixes including color scheme adjustments, icon handling, and styling improvements.

Changes:

  • Updated the primary blue color across the light theme from #005FB8 to #0069CC for better visual consistency
  • Fixed Apple button icon to use the light variant for both high contrast light and standard light themes
  • Added semi-transparent background to dialog boxes and removed button shadows from chat todo list widgets in light theme
  • Updated chat request bubble backgrounds and adjusted list highlight color in dark theme

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/chat/browser/chatSetup/media/chatSetup.css Adds .vs theme selector to use light Apple icon variant alongside high contrast light theme
extensions/theme-2026/themes/styles.css Adds semi-transparent background to dialog boxes and removes box shadows from todo list widget buttons in light theme
extensions/theme-2026/themes/2026-light.json Updates primary blue color scheme from #005FB8 to #0069CC across all UI elements and changes chat bubble backgrounds to solid colors
extensions/theme-2026/themes/2026-dark.json Changes list highlight foreground color from #bfbfbf to #48A0C7 for better visibility

"extensionButton.prominentBackground": "#0069CC",
"extensionButton.prominentForeground": "#FFFFFF",
"extensionButton.prominentHoverBackground": "#0D4FE8",
"extensionButton.prominentHoverBackground": "#0064CC",
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hover color for extension buttons (#0064CC) is inconsistent with the hover color for regular buttons (#0063C1). Since both extensionButton.prominentBackground and button.background use the same base color (#0069CC), their hover states should likely use the same darkening pattern. Consider changing extensionButton.prominentHoverBackground to #0063C1 to match button.hoverBackground.

Suggested change
"extensionButton.prominentHoverBackground": "#0064CC",
"extensionButton.prominentHoverBackground": "#0063C1",

Copilot uses AI. Check for mistakes.
@eli-w-king eli-w-king marked this pull request as ready for review January 27, 2026 00:50
@vs-code-engineering
Copy link

vs-code-engineering bot commented Jan 27, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/chatSetup/media/chatSetup.css

@eli-w-king eli-w-king enabled auto-merge January 27, 2026 00:50
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 27, 2026
@eli-w-king eli-w-king added the polish Cleanup and polish issue label Jan 27, 2026
@eli-w-king eli-w-king merged commit 58f407a into main Jan 28, 2026
22 checks passed
@eli-w-king eli-w-king deleted the eli/theme-fixes branch January 28, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2026-themes Issues related to the 2026 light and dark themes polish Cleanup and polish issue ux User experience issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants