Skip to content

Mark variables in zsh integration functions as local #290298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matt-sorenson wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mark variables in zsh integration functions as local #290298

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c71ee69
Mark variables in zsh integration functions as local so they don't po…
matt-sorenson Jan 25, 2026
684e81c
Merge branch 'main' into matt-sorenson/zsh-globals/1
matt-sorenson Jan 27, 2026
4063294
Merge branch 'main' into matt-sorenson/zsh-globals/1
matt-sorenson Feb 3, 2026
8bab2a2
Merge branch 'main' into matt-sorenson/zsh-globals/1
matt-sorenson Feb 12, 2026
20255b5
Merge branch 'main' into matt-sorenson/zsh-globals/1
matt-sorenson Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-rc.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ __update_env_cache_aa() {
__update_env_cache() {
local key="$1"
local value="$2"
local i

for (( i=1; i <= $#__vsc_env_keys; i++ )); do
if [[ "${__vsc_env_keys[$i]}" == "$key" ]]; then
Expand All @@ -197,6 +198,8 @@ __update_env_cache() {
}

__vsc_update_env() {
local key var value

if [[ ${#envVarsToReport[@]} -gt 0 ]]; then
builtin printf '\e]633;EnvSingleStart;%s;%s;\a' 0 $__vsc_nonce
if [ $__vsc_use_aa -eq 1 ]; then
Expand Down