media-preview: attempt to handle untitled scheme for Safari/Firefox (fix #236152) #290258
+55
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to fix audio/video preview for files opened via Safari's "Open Files..." dialog on vscode.dev.
untitled:scheme in audioPreview.ts and videoPreview.tsdata:URIs for media-srcLimitation
This fix cannot fully resolve the issue because
workspace.fs.readFile()cannot accessuntitled:scheme files.When files are opened via Safari's limited File API (browsers without full File System Access API support):
FileReaderinto memoryuntitled:scheme is createduntitled:URIsRoot Cause (needs core fix)
The
untitled:scheme is designed for text files, not binary files. A proper fix would require changes in VS Code's core - either:untitled:scheme)Related Issues
Test Plan