Optimize pytest duplicate check from O(n) to O(1) using set #25657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract command registration logic from UnitTestManagementService into standalone registerTestCommands function - Call registerTestCommands synchronously in activateLegacy before async operations - This ensures commands are available immediately when extension activates, preventing "command not found" errors Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
…vation - Register test services (unitTestsRegisterTypes) before any async operations in extension.ts - Register test commands immediately after service registration, before experimentService.activate() - Remove duplicate registrations from extensionActivation.ts activateLegacy() - This ensures commands are available synchronously when extension activates Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pytest hooks use a list to track collected tests and check for duplicates with if test_id not in collected_tests_so_far, which scales poorly for large test suites (O(n) per check). Switch to using a set