Skip to content

Conversation

@eleanorjboyd
Copy link
Member

fixes #523 and #855

@eleanorjboyd eleanorjboyd self-assigned this Sep 21, 2025
@vs-code-engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the September 2025 milestone Sep 21, 2025
@eleanorjboyd eleanorjboyd marked this pull request as draft September 21, 2025 23:47
@eleanorjboyd eleanorjboyd requested review from Copilot and karthiknadig and removed request for karthiknadig September 22, 2025 01:57
@eleanorjboyd eleanorjboyd marked this pull request as ready for review September 22, 2025 01:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds back button functionality to all necessary UI flows within the extension, addressing issues #523 and #855. The changes implement a step-based wizard pattern that allows users to navigate backward through the environment creation process.

  • Refactors the Conda environment creation flow to use a step-based wizard pattern with back navigation
  • Refactors the venv creation flow to support back navigation through all steps
  • Adds back button support to the PET (Python Environment Tool) terminal functionality
  • Updates various UI helpers to support back navigation through buttons

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/managers/conda/condaUtils.ts Exports utility functions and replaces inline flow with step-based Conda flow
src/managers/conda/condaStepBasedFlow.ts New file implementing step-based Conda environment creation with back navigation
src/managers/builtin/venvUtils.ts Replaces inline venv creation logic with step-based flow
src/managers/builtin/venvStepBasedFlow.ts New file implementing step-based venv creation with back navigation
src/helpers.ts Refactors PET terminal functionality to support back navigation
src/extension.ts Updates to use refactored PET terminal functionality
src/common/pickers/managers.ts Adds back button support to manager picker
Comments suppressed due to low confidence (2)

src/managers/conda/condaStepBasedFlow.ts:1

  • This creates infinite recursion. The function calls createCondaEnvironment which calls createStepBasedCondaFlow, but this code is already within that flow. The back navigation should return to the step-based flow, not restart the entire process.
import * as fse from 'fs-extra';

src/managers/conda/condaStepBasedFlow.ts:1

  • Same infinite recursion issue as above. This should return to the step-based flow rather than calling createCondaEnvironment again.
import * as fse from 'fs-extra';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vs-code-engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@eleanorjboyd eleanorjboyd merged commit 9e5fb7d into microsoft:main Oct 7, 2025
7 checks passed
@eleanorjboyd eleanorjboyd deleted the biological-grouse branch October 7, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure all quick picks have a way to exit (back button)

2 participants