get launch config from settings.json as fallback#585
Merged
eleanorjboyd merged 3 commits intomicrosoft:mainfrom Feb 13, 2025
Merged
get launch config from settings.json as fallback#585eleanorjboyd merged 3 commits intomicrosoft:mainfrom
eleanorjboyd merged 3 commits intomicrosoft:mainfrom
Conversation
eleanorjboyd
added
the
bug
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
karthiknadig
requested changes
Feb 10, 2025
Member
karthiknadig
left a comment
karthiknadig
left a comment
There was a problem hiding this comment.
Minor suggestion. getConfiguration is already defined in common/vscodeapis. We can just use that.
eleanorjboyd
force-pushed
the
yellow-bagel
branch
from
e185363 to
2d208c0
Compare
karthiknadig
approved these changes
Feb 12, 2025
eleanorjboyd
added a commit
to eleanorjboyd/vscode-python-debugger
that referenced
this pull request
Feb 14, 2025
* get launch config from settings.json as fallback * update error return * remove dup getConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #532