Add support for file upload when leaving a PR comment#8724
Open
alexr00 wants to merge 2 commits intoalexr00/raw-leoponfrom
Open
Add support for file upload when leaving a PR comment#8724alexr00 wants to merge 2 commits intoalexr00/raw-leoponfrom
alexr00 wants to merge 2 commits intoalexr00/raw-leoponfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable file-upload helper and wires it into both the PR/issue webview flow and the native VS Code comment editor so users can upload files and have placeholders replaced with the resulting markdown links.
Changes:
- Refactored file selection + parallel upload logic into a shared
fileUploadhelper module. - Updated the issue/PR overview webview flow to use the shared upload helper and callbacks.
- Added a new
pr.uploadFilecommand and surfaced it in comment editor actions (with localization/manifest updates).
Show a summary per file
| File | Description |
|---|---|
| src/github/issueOverview.ts | Replaces inlined file-pick + upload logic with shared helper calls and completion/error callbacks. |
| src/github/fileUpload.ts | Introduces shared utilities for picking files + running parallel uploads with per-upload callbacks. |
| src/commands.ts | Adds pr.uploadFile command to insert placeholders into comment editor and replace them as uploads complete. |
| package.nls.json | Adds localized title string for the new command. |
| package.json | Contributes the new command and adds it to comment editor actions/menus. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
benvillalobos
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #320