Draft
Conversation
ntrogh
requested review from
Copilot and
isidorn
and removed request for
Copilot
Contributor
|
@ntrogh thank you for pushing on this one. Is this PR ready for my review/feedback? |
Contributor
Author
|
@isidorn yes, feel free to review. Thanks |
isidorn
reviewed
Mar 30, 2026
|
|
||
| > [!NOTE] | ||
| > Terminal sandboxing is currently in preview and is only supported on macOS and Linux. On Windows, the sandbox settings have no effect. | ||
| > Terminal sandboxing is currently in preview and is only supported on macOS and Linux. On Windows, only WSL2 environments are supported. |
Contributor
There was a problem hiding this comment.
This puts Windows as not officially supported. But WSL might be the actual path forward. I would frame it slightly differently for windows to say that it uses WSL
isidorn
reviewed
Mar 30, 2026
| * Network access is blocked for all domains by default | ||
| * Commands run without the standard confirmation dialog | ||
| * Commands have read access to the entire file system | ||
| * Commands have write access only to the current working directory and its subdirectories |
Contributor
There was a problem hiding this comment.
@dileepyavan is this correct? What about the TMP directory - how are we treating it now?
isidorn
reviewed
Mar 30, 2026
| * Commands run without the user confirmation prompt | ||
|
|
||
| > [!IMPORTANT] | ||
| > If the required OS dependencies for sandboxing are not installed, VS Code shows a warning and runs commands without sandboxing. |
Contributor
There was a problem hiding this comment.
We handle this differently now, VS Code will offer to install those dependencies first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9588