Add Container Definition for COBOL#1280
Add Container Definition for COBOL#1280elswork wants to merge 2 commits intomicrosoft:mainfrom elswork:main
Conversation
|
Is something wrong with this PR? |
|
Please, can somebody review this PR? 👀 |
bamurtaugh
left a comment
bamurtaugh
left a comment
There was a problem hiding this comment.
Thank you for your submission @elswork! Left some comments in a review.
| Once the container is up and running, open container terminal and execute: | ||
|
|
||
| ``` | ||
| cobc -x main.cbl |
There was a problem hiding this comment.
After compiling, I received the warning:
main.cbl: 22: warning: line not terminated by a newline
There was a problem hiding this comment.
I've removed trailing white spaces in the cobol file and the warning message has disappeared.
| @@ -0,0 +1,32 @@ | |||
| # Use the [Choice] comment to indicate option arguments that should appear in VS Code UX. Use a comma separated list. | |||
There was a problem hiding this comment.
Could the cobol-gnucobol-2.2.0 folder have a simpler name, like cobol?
| RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ | ||
| && /bin/bash /tmp/library-scripts/common-debian.sh "${INSTALL_ZSH}" "${USERNAME}" "${USER_UID}" "${USER_GID}" "${UPGRADE_PACKAGES}" "true" "true"\ | ||
| # | ||
| # **************************************************************************** |
There was a problem hiding this comment.
Remove additional # comments to keep Docerkfile more concise?
|
|
||
| working-storage section. | ||
|
|
||
| 77 mensaje picture x(32) value 'Hello World!!!'. |
There was a problem hiding this comment.
Could you use message here and below instead?
There was a problem hiding this comment.
'message' is a reserved word I've switched it to 'imessage'
| @@ -0,0 +1,17 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Could there be guidance in the readme to explain how to use the test script?
There was a problem hiding this comment.
I've removed those script tests.
@bamurtaugh suggestion accepted Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
|
Created a new Pull Request #1330 |
2 participants
Add COBOL devcontainer to compile and run COBOL