Handle Background Agent requet when a tool call is pending #2550
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where Background Agent requests would incorrectly create duplicate sessions when a tool call was pending for an untitled session. The fix introduces a mapping to track untitled session IDs to their corresponding real session IDs, preventing duplicate session creation during subsequent requests to the same untitled session.
- Adds
untitledSessionIdMappingto track the relationship between untitled session IDs and their real session IDs - Introduces
isNewSessionlogic that distinguishes between first-time untitled sessions and subsequent requests to already-created untitled sessions - Updates session creation, worktree management, and cleanup logic to use the new
isNewSessioncheck
DonJayamanne
added
the
candidate
lramos15
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#282401