Add tests for enum query parameters with convenientAPI(false)#9984
Merged
jorgerangel-msft merged 2 commits intomicrosoft:mainfrom Mar 11, 2026
Merged
Conversation
radhgupta
requested review from
JoshLove-msft,
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
radhgupta
changed the title
Collaborator
|
You can try these changes here
|
Add test coverage to ensure enum types referenced by protocol methods are generated when @convenientAPI(false) is used. This validates the TCGC fix for the issue where enum types were missing from generated output. Fixes microsoft#8919 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radhgupta
force-pushed
the
fix/enum-protocol-method-8919
branch
from
9acad18 to
6af7c05
Compare
...crosoft.TypeSpec.Generator.ClientModel/test/Providers/ClientProviders/ClientProviderTests.cs
Show resolved
Hide resolved
jorgerangel-msft
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage to ensure enum types referenced by protocol methods are generated when @convenientAPI(false) is used. This validates the TCGC fix for the issue where enum types were missing from generated output.
Fixes #8919