Conversation
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
|
You can try these changes here
|
Contributor
|
All changed packages have been documented.
Show changes
|
…nges Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/2f94ce6d-ca3d-4e72-9cb1-201a89e8d177 Co-authored-by: l0lawrence <100643745+l0lawrence@users.noreply.github.com>
iscai-msft
requested review from
ChenxiJiang333,
catalinaperalta,
iscai-msft,
lmazuel,
msyyc,
swathipil,
tadelesh and
timotheeguerin
as code owners
iscai-msft
approved these changes
May 15, 2026
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/ce6fff89-aa07-4a38-881f-b8ac55b866c5 Co-authored-by: l0lawrence <100643745+l0lawrence@users.noreply.github.com>
…zer_name Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ted models The XML deserializer fast-path emits `functools.partial(_xml_deser_enum_or_str, EnumName)` in generated `_models.py`. That call is evaluated at class-body time, so `EnumName` must be in the module's runtime globals. Previously the enum import was routed to the `TYPE_CHECKING` block (see `EnumType.imports` for `NamespaceType.MODEL` + `called_by_property`), causing `NameError` at import time. Track each enum used as an XML deserializer and add a runtime `from ._enums import EnumName` import alongside the existing `_xml_deser_enum_or_str` import. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ing _enums Generated _models.py was emitting rom .._enums import Status because the relative path was computed against the enum's client_namespace (e.g. payload.xml) rather than the models subpackage where _enums.py actually resides (payload.xml.models). Use get_imported_namespace_for_model to target the sibling _enums module. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
@annatisch There is lint issue caused by this PR and here is log https://dev.azure.com/azure-sdk/public/_build/results?buildId=6308327&view=logs&jobId=fd717020-1679-5f7a-6b2c-cec8fe1b1f5d&j=fd717020-1679-5f7a-6b2c-cec8fe1b1f5d&t=42a547a8-180c-5677-1c47-e52963775ef |
… templates Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/7923e1b0-320c-4564-a96e-458926397afb Co-authored-by: l0lawrence <100643745+l0lawrence@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/7923e1b0-320c-4564-a96e-458926397afb Co-authored-by: l0lawrence <100643745+l0lawrence@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.