Adding GitHub Migration Process #121

v-jigen · 2018-05-03T18:35:34Z

No description provided.

msftclas · 2018-05-03T18:35:45Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ v-jigen sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Handle *.png as binary in .gitattributes

bpm-ms

In general I think there's fundamentally a disagreement in approach here. I think labels should be used to describe and classify an issue. This document seems to mix that with the project management aspect. I think we should look into something like Github Projects, ZenHub, or Waffle for tracking progress / doing project management. I also think we don't necessarily need all the granularity of "in-progress' "in-design" "understood" etc. Most projects are content with "Not started", "In Progress", "done". I also think for the majority of issues that come in, adding all these labels is needless overhead.

bpm-ms · 2018-05-15T00:19:41Z

github_migration_process.md

@@ -0,0 +1,222 @@
+Proposed labels by section on GitHub


I don't think this fits as the title of this document.

bpm-ms · 2018-05-15T00:20:18Z

github_migration_process.md

+Assignees
+---------------------------------------------------------------
+
+> No labels for this section - just use the alias of the individuals owning the issue. MS alias showing is preferred.


github aliases should and need to be used. For PM purposes you can figure out behind the scenes the mapping

bpm-ms · 2018-05-15T00:20:43Z

github_migration_process.md

+Labels
+------------------------------------------------------------
+
+> It is understood that some teams will have their OWN GItHub page. Focus is on the SF page and we can build on/modify for other Team GitHub pages later once the initial model is completed.


nit: GItHub -> GitHub
nit: OWN -> own

bpm-ms · 2018-05-15T00:21:41Z

github_migration_process.md

+
+-   All tags and labels are lower-case and dash separated
+
+-   All hierarchy is whack separated and no caps.


I think whack is technically backslash 😆, maybe say "forward slash" or /

bpm-ms · 2018-05-15T00:23:47Z

github_migration_process.md

+
+| ***State/Status*** | ***Area***               | ***Issue Type*** | ***Pri***       |
+|--------------------|--------------------------|------------------|-----------------|
+| investigating      | area-common              | question         | Pri-0,(regular) |


what does (regular) mean?

bpm-ms · 2018-05-15T00:45:49Z

github_migration_process.md

+>
+> **Important! The Bug or Enhancement will remain un-assigned until someone is ready to pick up the work!** We do not want to just assign items to people who have work already since it is possible others may want to contribute to the fix/feature.
+>
+> At the very least the issue can be assigned a future Milestone if it is understood that is where the work needs to be done **OR** if there is not a clear path for the bug, leaving the Milestone blank functions as a backlog for issues without a release assigned. Once it reaches the current Milestone, the additional labels may be added.


bpm-ms · 2018-05-15T00:46:12Z

github_migration_process.md

+>
+> ***'Optional' Phases will apply to issues that are immediately understood allowing them to bypass many of the phases, moving the bug right to 'in-progress'.***
+
+****Enhancement Issues****


you seem to have this on here twice?

bpm-ms · 2018-05-15T00:47:55Z

github_migration_process.md

+| **Contributors**: | Community members that make any contribution to the project, whether it’s submitting code, fixing or reporting bugs, writing docs, etc.|
+| **Users:**        | General users who have a need for the project.|
+
+> **As a measurement** we want to try and touch all new items within 48 hours. This is not exposed to the customer but is a metric for us to determine how quickly we are touching new issues. We need to ensure that feature area owners are actively triaging their issues and keeping them up to date.


This document is on public github, so yes it is exposed to the customer. Also, while there will be "customers" using the product, there are also "contributors" who are helping build the product. We should be considerate to not call everyone who is filing issues a "customer" because they may very well be a contributor who wants to be part of the development community and work on service fabric, as opposed to just using service fabric.

bpm-ms · 2018-05-15T00:48:18Z

github_migration_process.md

+>
+> A defined group of individuals consisting of Area Leads or Developers will be responsible for reviewing all new items.
+>
+> Once a new item has arrived the defined resource for 'touching' these issues for the first time will set the label 'triage' to the issue so that it can be reviewed.


"defined resource for 'touching' these issues" sounds really weird. Maybe find a word for that?

bpm-ms · 2018-05-15T00:49:56Z

github_migration_process.md

+>
+> Once all work is completed and signed off on, we can RTW and close-down the Milestone and move any remaining items into the appropriate/next Milestone.
+
+Work Flow Process Table (Same as above - fewer words)


If these say the same thing, lets use the one with fewer words. That makes us have less copies to maintain and update as we change.

…to v-jigen-master

…abric into v-jigen-master" This reverts commit c141772, reversing changes made to 3f670fd.

samedder · 2018-05-22T21:58:11Z

@bpm-ms I added my edits, let me know if this seems better. I removed the entire last section with a bunch of workflows I think that made the document too complicated.

* Fix the logics to check if the object is serializable.

spaletta and others added 2 commits April 14, 2018 00:32

Handle *.png as binary in .gitattributes

3cd6e45

Adding GitHub Migration Process

3f670fd

samedder and others added 3 commits May 9, 2018 18:48

Merge branch 'master' into fix-gitattributes-for-png

2ca2723

Merge pull request microsoft#88 from spaletta/fix-gitattributes-for-png

15b6be4

Handle *.png as binary in .gitattributes

Fix typo in ThirdPartyNotices.txt and migrate to UTF-8 (microsoft#117)

31c5679

bpm-ms self-requested a review May 14, 2018 22:03

bpm-ms suggested changes May 15, 2018

View reviewed changes

samedder added 6 commits May 22, 2018 13:06

Merge branch 'master' of https://github.com/v-jigen/service-fabric in…

c141772

…to v-jigen-master

Moving file to new location

76443b3

Adding in-person changes

6bc88f0

Revert "Merge branch 'master' of https://github.com/v-jigen/service-f…

6c92605

…abric into v-jigen-master" This reverts commit c141772, reversing changes made to 3f670fd.

Adding edits

2370fcb

Rewriting

cbc7ad5

ammarZaidi pushed a commit to ammarZaidi/service-fabric that referenced this pull request Sep 25, 2018

Fix the logics to check if the object is serializable. (microsoft#121)

4ea2b77

* Fix the logics to check if the object is serializable.


		- All tags and labels are lower-case and dash separated

		- All hierarchy is whack separated and no caps.

Adding GitHub Migration Process #121

Are you sure you want to change the base?

Adding GitHub Migration Process #121

Uh oh!

Conversation

v-jigen commented May 3, 2018

Uh oh!

msftclas commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bpm-ms left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samedder commented May 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

msftclas commented May 3, 2018 •

edited

Loading