Skip to content

Python: feat: Add AgentAuditHandler for EU AI Act compliance#14042

Open
kuriangeorgebinu wants to merge 1 commit into
microsoft:mainfrom
kuriangeorgebinu:issue-14034-agent-audit
Open

Python: feat: Add AgentAuditHandler for EU AI Act compliance#14042
kuriangeorgebinu wants to merge 1 commit into
microsoft:mainfrom
kuriangeorgebinu:issue-14034-agent-audit

Conversation

@kuriangeorgebinu
Copy link
Copy Markdown

Addresses issue #14034
Initial implementation of AgentAuditHandler middleware for recording and tracking AI agent actions for compliance purposes. Features:

  • Audit trail logging for all agent actions
  • EU AI Act compliance support (Articles 12, 73, 9, 11)
  • Integration framework for AgentAudit AI service
  • Compliance report generation capability
  • Immutable audit record structure This is a foundational implementation open for community feedback on:
  • Design approach for the audit handler interface
  • Integration points with agent execution pipeline
  • Compliance requirements mapping to implementation
  • Blockchain audit trail integration strategy Co-authored-by: GitHub Copilot

Motivation and Context

Description

Contribution Checklist

Addresses issue microsoft#14034
Initial implementation of AgentAuditHandler middleware for recording and
tracking AI agent actions for compliance purposes.
Features:
- Audit trail logging for all agent actions
- EU AI Act compliance support (Articles 12, 73, 9, 11)
- Integration framework for AgentAudit AI service
- Compliance report generation capability
- Immutable audit record structure
This is a foundational implementation open for community feedback on:
- Design approach for the audit handler interface
- Integration points with agent execution pipeline
- Compliance requirements mapping to implementation
- Blockchain audit trail integration strategy
Co-authored-by: GitHub Copilot
Copilot AI review requested due to automatic review settings May 28, 2026 15:54
@kuriangeorgebinu kuriangeorgebinu requested a review from a team as a code owner May 28, 2026 15:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Introduces a new AgentAuditHandler scaffold under semantic_kernel.agents.audit intended to provide an EU AI Act compliance audit trail for agent actions. The core logging and reporting logic is not yet implemented (TODOs).

Changes:

  • Adds a new audit subpackage under semantic_kernel.agents.
  • Introduces AgentAuditHandler class with initialize, log_agent_action, generate_compliance_report, and close methods (mostly stubs).
  • Exports AgentAuditHandler from the package's __init__.py.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
python/semantic_kernel/agents/audit/init.py Creates the new audit package and exposes AgentAuditHandler.
python/semantic_kernel/agents/audit/agent_audit_handler.py Adds the new handler class with placeholder implementations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +58 to +64
async def log_agent_action(
self,
agent_name: str,
action_type: str,
action_details: dict[str, Any],
timestamp: Optional[str] = None,
) -> None:
Comment on lines +86 to +90
"action_details": action_details,
"timestamp": timestamp,
}

logger.debug(f"Recording audit entry: {audit_record}")
Comment on lines +55 to +56
logger.info(f"Initializing AgentAuditHandler with service: {self.service_url}")
self._validated = True
Comment on lines +5 to +6
import logging
from typing import Any, Optional
agent_name: str,
action_type: str,
action_details: dict[str, Any],
timestamp: Optional[str] = None,
logger = logging.getLogger(__name__)


class AgentAuditHandler:
@moonbox3 moonbox3 added the python Pull requests for the Python Semantic Kernel label May 28, 2026
@github-actions github-actions Bot changed the title feat: Add AgentAuditHandler for EU AI Act compliance Python: feat: Add AgentAuditHandler for EU AI Act compliance May 28, 2026
@microsoft-github-policy-service
Copy link
Copy Markdown

@kuriangeorgebinu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Code Review

Reviewers: 4 | Confidence: 91%

✓ Correctness

The existing unresolved review comments comprehensively cover the significant correctness issues in this PR (timestamp not defaulted despite docstring claim, initialize() not validating connectivity, log_agent_action being a misleading no-op, sensitive data logging, Optional style inconsistency, and missing tests). Beyond those already-flaged issues, I found no additional correctness bugs. The code is internally consistent for a stub implementation, but the already-identified issues remain valid blockers for a compliance-oriented component.

✓ Security Reliability

The primary new security concern (beyond the already-flagged issues) is that the api_key is stored as a plain string attribute, contradicting the established codebase pattern of using Pydantic's SecretStr. This means the credential can be exposed via object repr, dict access, serialization, or any inadvertent logging of the handler instance — particularly problematic for a module whose purpose is security compliance.

✓ Test Coverage

This PR adds a new AgentAuditHandler class with zero accompanying unit tests. The repository has a well-established pattern of unit tests under python/tests/unit/agents/ for every agent module (e.g., test_agent.py, test_bedrock_agent.py, test_azure_ai_agent.py). The new audit module ships without any test coverage, meaning all code paths (initialize success/failure, log_agent_action when disabled/uninitialized/valid, generate_compliance_report when disabled/uninitialized/valid, and close) are untested. This is a blocking gap for a compliance-oriented component where correctness is critical.

✗ Design Approach

The main design issue is that this PR introduces a standalone audit helper, but it does not integrate with the agent runtime’s existing interception pipeline, so it cannot deliver the stated goal of auditing all agent actions on the normal execution path. I did not find other design findings that met the repo’s evidence bar without duplicating existing review comments.

Flagged Issues

  • The new audit handler is not integrated with the runtime-wide InterventionHandler hook that already intercepts every send/publish/response in InProcessRuntime. The repo's established pattern (python/semantic_kernel/agents/runtime/core/intervention.py:29-39) is explicitly designed for components that "modify, log or drop messages." Because AgentAuditHandler is a standalone class, normal agent traffic will never reach it automatically, and the stated goal of auditing all agent actions is not achieved by the current design.

Automated review by kuriangeorgebinu's agents

"""
self.service_url = service_url
self.api_key = api_key
self.enabled = enabled
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: api_key is stored as a plain str attribute, which means it can leak via repr(), __dict__, serialization, or accidental logging of this object. The rest of the SK Python codebase (e.g., openai_assistant_agent.py) uses Pydantic's SecretStr to wrap API keys. For a compliance-oriented module this is especially important—store as SecretStr and call .get_secret_value() only when transmitting to the service.

Suggested change
self.enabled = enabled
self.api_key: SecretStr | None = SecretStr(api_key) if api_key else None

raise ValueError("api_key is required when audit logging is enabled")

logger.info(f"Initializing AgentAuditHandler with service: {self.service_url}")
self._validated = True
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service_url is logged at INFO level. If a user supplies a URL with embedded credentials or tokens as query parameters (e.g., https://service.example.com?token=secret), those will be written to application logs. Consider logging only the scheme+host or omitting the URL entirely.

Suggested change
self._validated = True
logger.info("AgentAuditHandler initialized successfully")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants