Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix \"Unknown env config\" warnings from npm during rush-pnpm operations (e.g. publish) by passing pnpm configuration via CLI args instead of NPM_CONFIG_* environment variables.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
14 changes: 9 additions & 5 deletions libraries/rush-lib/src/cli/RushPnpmCommandLineParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -432,12 +432,16 @@ export class RushPnpmCommandLineParser {
const rushConfiguration: RushConfiguration = this._rushConfiguration;
const workspaceFolder: string = this._subspace.getSubspaceTempFolderPath();
const pnpmEnvironmentMap: EnvironmentMap = new EnvironmentMap(process.env);
pnpmEnvironmentMap.set('NPM_CONFIG_WORKSPACE_DIR', workspaceFolder);

// Pass pnpm configuration as CLI args rather than NPM_CONFIG_* environment variables.
// Using env vars like NPM_CONFIG_STORE_DIR would cause "Unknown env config" warnings
// when pnpm internally delegates to npm (e.g. during publish operations).
const pnpmConfigArgs: string[] = [`--config.workspaceDir=${workspaceFolder}`];

if (rushConfiguration.pnpmOptions.pnpmStorePath) {
pnpmEnvironmentMap.set('NPM_CONFIG_STORE_DIR', rushConfiguration.pnpmOptions.pnpmStorePath);
pnpmEnvironmentMap.set('NPM_CONFIG_CACHE_DIR', rushConfiguration.pnpmOptions.pnpmStorePath);
pnpmEnvironmentMap.set('NPM_CONFIG_STATE_DIR', rushConfiguration.pnpmOptions.pnpmStorePath);
pnpmConfigArgs.push(`--store-dir=${rushConfiguration.pnpmOptions.pnpmStorePath}`);
pnpmConfigArgs.push(`--config.cacheDir=${rushConfiguration.pnpmOptions.pnpmStorePath}`);
pnpmConfigArgs.push(`--config.stateDir=${rushConfiguration.pnpmOptions.pnpmStorePath}`);
}

if (rushConfiguration.pnpmOptions.environmentVariables) {
Expand Down Expand Up @@ -473,7 +477,7 @@ export class RushPnpmCommandLineParser {
try {
const { exitCode } = await Utilities.executeCommandAsync({
command: rushConfiguration.packageManagerToolFilename,
args: this._pnpmArgs,
args: [...pnpmConfigArgs, ...this._pnpmArgs],
workingDirectory: process.cwd(),
environment: pnpmEnvironmentMap.toObject(),
keepEnvironment: true,
Expand Down
Loading