feat(yarn-plugin-eslint): Yarn plugin with integrated ESLint command#3577
Draft
feat(yarn-plugin-eslint): Yarn plugin with integrated ESLint command#3577
Conversation
github-actions
bot
added
chore
tido64
commented
Apr 10, 2025
Comment on lines
+8
to
+13
| if (importedConfigFileModificationTime.get(filePath) !== mtime) { | ||
| - delete require.cache[filePath]; | ||
| + if (require.cache) { | ||
| + delete require.cache[filePath]; | ||
| + } | ||
| } |
Member
Author
There was a problem hiding this comment.
This needs to be upstreamed.
JasonVMo
reviewed
Apr 10, 2025
Collaborator
JasonVMo
left a comment
JasonVMo
left a comment
There was a problem hiding this comment.
Played around with this a bit and I'm not sure having everything built into the plugin is the right approach though we can start with this. I'll try to put together a draft package tomorrow to play with a slight alternative idea.
|
|
||
| 🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧 | ||
|
|
||
| This is a Yarn plugin that integrates ESLint and opinionated (but overridable) |
Collaborator
There was a problem hiding this comment.
Reminder to add information about how it can be overridden and what the opinionated defaults are.
tido64
force-pushed
the
tido/yarn/plugin-eslint
branch
from
7948253 to
ac08e1d
Compare
tido64
force-pushed
the
tido/yarn/plugin-eslint
branch
from
ac08e1d to
774951c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a Yarn plugin with integrated ESLint and opinionated defaults
Test plan
cd incubator/yarn-plugin-eslint yarn bundle.yarnrc.yml:yarn rnx-lint