Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .ado/jobs/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ jobs:
- script: yarn lint
displayName: yarn lint

- script: yarn validate-overrides
displayName: yarn validate-overrides
${{ if eq(parameters.buildEnvironment, 'Continuous') }}:
env:
PLATFORM_OVERRIDE_GITHUB_TOKEN: $(GitHubOAuthToken)
# Disable while facebook/react-native -> react/react-native migration breaks CI
# - script: yarn validate-overrides
# displayName: yarn validate-overrides
# ${{ if eq(parameters.buildEnvironment, 'Continuous') }}:
# env:
# PLATFORM_OVERRIDE_GITHUB_TOKEN: $(GitHubOAuthToken)

- script: npx unbroken -q --local-only --allow-local-line-sections
displayName: check local links in .md files
Expand Down
5 changes: 3 additions & 2 deletions .ado/jobs/macos-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ jobs:
- script: yarn test
displayName: yarn test

- script: yarn validate-overrides
displayName: yarn validate-overrides
# Disable while facebook/react-native -> react/react-native migration breaks CI
# - script: yarn validate-overrides
# displayName: yarn validate-overrides
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix crash attempting to get runtime when shutting down instance",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion vnext/Microsoft.ReactNative.Cxx/NativeModules.h
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,8 @@ struct ModuleJsiInitMethodInfo<void (TModule::*)(ReactContext const &, facebook:
return
[module = static_cast<ModuleType *>(module), method](
ReactContext const &reactContext, winrt::Windows::Foundation::IInspectable const &runtimeHandle) noexcept {
(module->*method)(reactContext, GetOrCreateContextRuntime(reactContext, runtimeHandle));
if (runtimeHandle)
(module->*method)(reactContext, GetOrCreateContextRuntime(reactContext, runtimeHandle));
};
}
};
Expand Down
Loading