Skip to content

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Jun 25, 2025

Description

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

While building an app in the New Architecture template, if you use either <Flyout /> or <Popup /> you'll be met with the unsupported Fabric view red box. This error is displayed from RN core.

Additionally, we can display a Metro warning to make the error more clear to the user - that they should be migrating to <Modal />

Resolves #14671

What

  1. Detects if we're running Fabric via global.nativeFabricUIManager
  2. Outputs a warning via console.warn in the contructors of Flyout and Popup

Screenshots

Collapsed Warning Expanded Warning
image image

Testing

Manually tested by editing node_modules\react-native-windows\Libraries\Components\Flyout\Flyout.js

Changelog

Should this change be included in the release notes: No

Microsoft Reviewers: Open in CodeFlow

@frankcalise frankcalise requested a review from a team as a code owner June 25, 2025 12:25
@acoates-ms
Copy link
Contributor

Please run yarn change to generate a change file for this change.
And I think we should probably use the warnOnce method to display the warning?

@frankcalise
Copy link
Contributor Author

@acoates-ms sure thing, should it bump the prelease version if it is just a warning in this case?

@acoates-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@chiaramooney chiaramooney merged commit e7fd8ad into microsoft:main Jul 3, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add metro warning for Flyout/Popup in NewArch

4 participants