chore(bidi): ignore exception when trying to get a frame's name#39657
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Mar 13, 2026
Merged
chore(bidi): ignore exception when trying to get a frame's name#39657yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Test results for "tests 1"4 flaky38691 passed, 846 skipped Merge workflow run. |
Contributor
Test results for "MCP"2 failed 5273 passed, 172 skipped Merge workflow run. |
yury-s
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bidi protocol doesn't include a frame's name in the
browsingContext.contextCreatedevent, so Playwright needs to request it in another command after receiving that event (see #38129), which may throw if the frame has already been destroyed.This issue makes several tests flaky (I've seen the corresponding error message in 15 tests in CI).