Skip to content

chore(bidi): ignore exception when trying to get a frame's name#39657

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
hbenl:ignore-getframenode-exception
Mar 13, 2026
Merged

chore(bidi): ignore exception when trying to get a frame's name#39657
yury-s merged 1 commit intomicrosoft:mainfrom
hbenl:ignore-getframenode-exception

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Mar 13, 2026

The Bidi protocol doesn't include a frame's name in the browsingContext.contextCreated event, so Playwright needs to request it in another command after receiving that event (see #38129), which may throw if the frame has already been destroyed.
This issue makes several tests flaky (I've seen the corresponding error message in 15 tests in CI).

@github-actions
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:1230 › should display language-specific locators `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1230 › should display language-specific locators `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test `@ubuntu-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:433 › should work behind reverse proxy `@macos-latest-node20`

38691 passed, 846 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

2 failed
❌ [webkit] › mcp/dashboard.spec.ts:45 › should pick locator from browser @mcp-ubuntu-latest
❌ [webkit] › mcp/dashboard.spec.ts:45 › should pick locator from browser @mcp-windows-latest

5273 passed, 172 skipped


Merge workflow run.

@yury-s yury-s merged commit 3bb46d4 into microsoft:main Mar 13, 2026
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants