Skip to content

chore(mcp): support --extesnsion in cli #38979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yury-s merged 2 commits into from
Jan 28, 2026
Merged

chore(mcp): support --extesnsion in cli #38979

yury-s merged 2 commits into from
Jan 28, 2026
+24 −17

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Jan 27, 2026

@yury-s yury-s force-pushed the mcp-cli-extension-arg branch from 30288f2 to 9c79d3e Compare January 27, 2026 02:14
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@yury-s yury-s force-pushed the mcp-cli-extension-arg branch 2 times, most recently from facc044 to 749961c Compare January 28, 2026 00:05
@yury-s yury-s force-pushed the mcp-cli-extension-arg branch from 749961c to 1fe7a7f Compare January 28, 2026 00:20
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
pavelfeldman approved these changes Jan 28, 2026
View reviewed changes
packages/playwright/src/mcp/browser/config.ts
const defaultDaemonConfig = (cliOptions: CLIOptions) => mergeConfig(defaultConfig, {
browser: {
userDataDir: '<daemon-data-dir>',
userDataDir: cliOptions.extension ? undefined : '<daemon-data-dir>', // Use default user profile with extension.
Copy link
Member

@pavelfeldman pavelfeldman Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this in the client btw

@yury-s yury-s merged commit 51b1d43 into microsoft:main Jan 28, 2026
5 of 6 checks passed
@yury-s yury-s deleted the mcp-cli-extension-arg branch January 28, 2026 00:56
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

Test results for "MCP"

15 failed
❌ [chrome] › mcp/http.spec.ts:263 › http transport shared context @mcp-macos-15
❌ [chrome] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:149 › core › dialog-accept @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:209 › keyboard › press @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:218 › keyboard › keydown keyup @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:265 › save as › screenshot @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:280 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:426 › session › session-stop named session @mcp-macos-15
❌ [chromium] › mcp/core.spec.ts:158 › browser_resize @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:79 › persistent context @mcp-macos-15
❌ [chromium] › mcp/planner.spec.ts:131 › planner_setup_page with dependencies @mcp-macos-15
❌ [chromium] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:315 › devtools › console --clear @mcp-macos-15
❌ [webkit] › mcp/planner.spec.ts:69 › planner_setup_page seed resolution @mcp-macos-15

3444 passed, 116 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s @pavelfeldman