Skip to content

test: unflake test_context_add_cookies_should_work #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Aug 5, 2025
Merged

test: unflake test_context_add_cookies_should_work #2935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/async/test_defaultbrowsercontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ async def test_context_add_cookies_should_work(
]
)
assert await page.evaluate("() => document.cookie") == "username=John Doe"
assert await page.context.cookies() == [
assert _filter_cookies(await page.context.cookies()) == [
{
"name": "username",
"value": "John Doe",
Expand All @@ -127,7 +127,7 @@ async def test_context_add_cookies_should_work(

def _filter_cookies(cookies: Sequence[Cookie]) -> List[Cookie]:
return list(
filter(lambda cookie: cookie["domain"] != "copilot.microsoft.com", cookies)
filter(lambda cookie: not cookie["domain"].endswith("microsoft.com"), cookies)
)


Expand Down
Loading