Skip to content

Use tmp file when downloading driver #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 8 commits into from
May 2, 2025
+5 −2
Merged

Use tmp file when downloading driver #2838

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2018e49
Speed up connection by not asking for context when inspecting stack
neoncube2 Apr 29, 2025
5a92f4f
Formatting changes from the pre-commit hook
neoncube2 Apr 29, 2025
e973932
Also use inspect.stack(0) for the sync version of _connect
neoncube2 Apr 29, 2025
ebddce4
Fix pre-commit warnings
neoncube2 Apr 29, 2025
d68cacf
Fix pre-commit warnings
neoncube2 Apr 29, 2025
5ac20ef
Simplify test cases, so that they pass on all browsers
neoncube2 Apr 29, 2025
2a08bac
Merge branch 'main' of https://github.com/neoncube2/playwright-python
neoncube2 Apr 30, 2025
74d85c7
Use tmp file during driver download, to protect against transient errors
neoncube2 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ def extractall(zip: zipfile.ZipFile, path: str) -> None:

def download_driver(zip_name: str) -> None:
zip_file = f"playwright-{driver_version}-{zip_name}.zip"
if os.path.exists("driver/" + zip_file):
destination_path = "driver/" + zip_file
if os.path.exists(destination_path):
return
url = "https://playwright.azureedge.net/builds/driver/"
if (
Expand All @@ -109,9 +110,11 @@ def download_driver(zip_name: str) -> None:
):
url = url + "next/"
url = url + zip_file
temp_destination_path = destination_path + ".tmp"
print(f"Fetching {url}")
# Don't replace this with urllib - Python won't have certificates to do SSL on all platforms.
subprocess.check_call(["curl", url, "-o", "driver/" + zip_file])
subprocess.check_call(["curl", url, "-o", temp_destination_path])
os.rename(temp_destination_path, destination_path)


class PlaywrightBDistWheelCommand(BDistWheelCommand):
Expand Down
Loading