chore: roll 1.55.0 #1827
Merged
chore: roll 1.55.0 #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Aug 19, 2025
yury-s
reviewed
Aug 19, 2025
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Test expectations need to be updated.
Skn0tt
commented
Aug 19, 2025
Member
Author
There was a problem hiding this comment.
These tests were replaced upstream in microsoft/playwright#36472. I dropped it here, don't think there's a big value from having it here.
Member
There was a problem hiding this comment.
Let's port the new tests, at least some of them? Otherwise there is 0 coverage for that in java.
mxschmitt
approved these changes
Aug 20, 2025
Member
Author
|
Mirroring the offline discussion here: the extension tests depend on service workers, but that feature isn't available in Java and Dotnet. So we don't test it. |
mxschmitt
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1819