chore: roll 1.54.0-alpha-2025-07-09 #1817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
commented
Jul 8, 2025
| * @since v1.8 | ||
| */ | ||
| String type(); | ||
| ConsoleMessageType type(); |
Member
Author
There was a problem hiding this comment.
This leads to pretty big diffs, see the diff in TestPageEventConsole.java. Unsure if it's worth it in Java.
There was a problem hiding this comment.
Yeah, we can leave it as string for now.
dgozman
reviewed
Jul 8, 2025
| * @since v1.8 | ||
| */ | ||
| String type(); | ||
| ConsoleMessageType type(); |
There was a problem hiding this comment.
Yeah, we can leave it as string for now.
| * limitations under the License. | ||
| */ | ||
|
|
||
| // This file is generated by generate_java_rpc.js, do not edit manually. |
Member
Author
There was a problem hiding this comment.
I couldn't find the generate_java_rpc.js file, so I don't think so :D
dgozman
reviewed
Jul 8, 2025
| if (newEnum.jsonName == null) { | ||
| throw new RuntimeException("Enum without name: " + jsonObject); | ||
| } | ||
| if ("ConsoleMessageType".equals(newEnum.jsonName)) { |
There was a problem hiding this comment.
The right way to handle this is to land a non-js override upstream in the docs.
Skn0tt
changed the title
dgozman
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1796