chore: roll 1.53.0 #1801
Merged
chore: roll 1.53.0 #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
changed the title
dgozman
reviewed
Jun 11, 2025
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserTypeImpl.java
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserTypeImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java
Outdated
Show resolved
Hide resolved
yury-s
approved these changes
Jun 11, 2025
| options.recordHarContent = null; | ||
| options.recordHarUrlFilter = null; | ||
| } else { | ||
| if (options.recordHarOmitContent != null) { |
Member
Author
There was a problem hiding this comment.
I dropped them accidentally! good catch. I added them back in.
There was a problem hiding this comment.
+1, I guess there are no tests for this 😄
playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java
Outdated
Show resolved
Hide resolved
playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java
Outdated
Show resolved
Hide resolved
| ExpectedTextValue expected = new ExpectedTextValue(); | ||
| expected.string = classname; | ||
| expectImpl("to.contain.class", expected, classname, "Locator expected to contain class", convertType(options, FrameExpectOptions.class)); | ||
| expectImpl("to.contain.class", expected, classname, "Locator expected to contain class", convertType(options, FrameExpectOptions.class), "Assert \"containsClass\""); |
Member
There was a problem hiding this comment.
Maybe "assertThat().containsClass()" ?
Member
Author
There was a problem hiding this comment.
Dotnet uses Expect "ToContainClassAsync" - let's mirror that wording for now. https://github.com/microsoft/playwright-dotnet/blob/1320cc6d92eac27c68040ddf91206be12297989a/src/Playwright/Core/LocatorAssertions.cs#L151
| } | ||
|
|
||
| @Test | ||
| @DisabledIf(value="com.microsoft.playwright.TestBase#isChromium", disabledReason="skip") |
Member
There was a problem hiding this comment.
Do we now support pdf in ff and wk?
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I don't see why it can't be tested on the client end even if the place where the error is thrown was moved to the server.
dgozman
approved these changes
Jun 12, 2025
| this.baseUrl = new URL(spec); | ||
| } catch (MalformedURLException e) { | ||
| this.baseUrl = null; | ||
| void setRecordHar(Path path, HarContentPolicy policy) { |
| options.recordHarContent = null; | ||
| options.recordHarUrlFilter = null; | ||
| } else { | ||
| if (options.recordHarOmitContent != null) { |
There was a problem hiding this comment.
+1, I guess there are no tests for this 😄
dgozman
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.